Skip to content

[17.0][MIG] survey_legal: Migration to version 17.0#166

Merged
OCA-git-bot merged 9 commits intoOCA:17.0from
Tecnativa:17.0-mig-survey_legal
May 12, 2025
Merged

[17.0][MIG] survey_legal: Migration to version 17.0#166
OCA-git-bot merged 9 commits intoOCA:17.0from
Tecnativa:17.0-mig-survey_legal

Conversation

@pilarvargas-tecnativa
Copy link
Copy Markdown

@pilarvargas-tecnativa pilarvargas-tecnativa commented May 6, 2025

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-survey_legal branch 2 times, most recently from b65f75d to f08ee27 Compare May 6, 2025 13:36
Copy link
Copy Markdown

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Please squash the administrative commits

chienandalu and others added 9 commits May 6, 2025 17:39
Aside from migration adaptations:

- Drop website_require_legal dependency
- Validation is now performed in js insead of the view so we need to do
  so.
- Additional control for the legal terms link and text

TT44775
Currently translated at 22.2% (2 of 9 strings)

Translation: survey-15.0/survey-15.0-survey_legal
Translate-URL: https://translation.odoo-community.org/projects/survey-15-0/survey-15-0-survey_legal/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: survey-15.0/survey-15.0-survey_legal
Translate-URL: https://translation.odoo-community.org/projects/survey-15-0/survey-15-0-survey_legal/es/
@pilarvargas-tecnativa
Copy link
Copy Markdown
Author

LGTM, Please squash the administrative commits

done :D

Copy link
Copy Markdown

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot migration survey_legal

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 6, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request May 6, 2025
17 tasks
@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-166-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f003284. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 7d0f4dd into OCA:17.0 May 12, 2025
7 checks passed
@pedrobaeza pedrobaeza deleted the 17.0-mig-survey_legal branch May 12, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants